Hi Guys,

I came up with this problem whilst using a FormView, i had my footertemplate with some buttons that would only be shown on edit or insert, even setting visible to false it was always showing..

So i've noticed the BuildRow method on CompositeDataBoundControlAdapter, wasn't verifying if the row is to be shown or not... So i decided to share this fix for any interested ppl.

Simple fix below, on line 158 of CompositeDataBoundControlAdapter.cs change:

if (bHasContent)

To  

if (bHasContent && row.Visible)

Regards,

Please DON'T include this fix...it is the wrong approach.  Visible is not the same as Enabled. Things that are not Visible should still be rendered to the client, with a style of display:none.  If you don't emit the elements then it is not possible for client-side code to display the element without a round-trip to the server (or things like hovers working).

So, the right thing to change is for all the places that render rows that could be set to Visible = false to emit the correct style on the tag.

This fix is already integrated into the RTM 1.0 release of the kit.  I understand what you mean when you say that you want client-side control over the visibility.  However, the Visible attribute for server-side ASP.NET has always (since 1.0 of the framework) strictly meant that the content of that server-side tag would not be rendered to the client.  You and I and others on this forum can discuss how we might the adapters to handle that differently in the future... but let's do that holistically, over all the adapters uniformly, and after we've thought through the ramifications.  Remember, you are proposing to change the essential meaning of Visible from "not rendered by the framework" to rendered by display:none.  Personally, I don't want adapters that put display:none in inline styles on my markup so that means that it has to be in classes that are, hopefully, in external style sheets.  If so, how do we enforce that?  I suppose the adapters could be modified to render this Visible=false content but mark it with a known CSS class like AspNet-FormView-Invisible which the author would have to define as display:none.

Still, that seems like a confusing way to approach this.  If you want to do this then why not simply skip setting Visible=false in the server-side markup/code and use CssClass or other means to simply set display:none on whatever elements you want to... and then reset that to display:block (etc) via whatever JS you want to build up (using home-grown JS or something form ASP.NET AJAX).

Just my 2cents.

I'm a moron... Visible is the guy that prevents rendering... my mistake.